Closed samreid closed 2 years ago
Looks like this problem was introduced in https://github.com/phetsims/sun/commit/53706aa5fef79d0805840dbd7e4a04b3a555ef9e for https://github.com/phetsims/sun/issues/733. I'll check it out.
The problem is present in usages of VSlider that do not specify both options trackSize
and thumbSize
.
These uses specify both trackSize and thumbSize and do not exhibit this problem:
These uses do NOT specify both trackSize and thumbSize, and do exhibit this problem:
Fixed in the above commits. Tested all sims listed in https://github.com/phetsims/sun/issues/733#issuecomment-1009379945, as well as a random sampling of HSliders.
Back to @samreid for review.
The changes seem good, thanks! Closing.
Discovered in https://github.com/phetsims/bamboo/issues/50, if you create a default VSlider with default
trackSize
andthumbSize
, the sliders look like this, but drag up and down:So perhaps VSlider should use different defaults, like this (but with factored out constants):
Or perhaps if Slider detects
orientation: Orientation.HORIZONTAL
, it should swap widths and heights. Assigning @pixelzoom since this issue may be related to https://github.com/phetsims/sun/issues/380