Closed pixelzoom closed 2 years ago
RoundButton isn't using PhET's dispose convention. It's defining dispose in the constructor. It should be a method that calls this.diposeRoundButton.
dispose
this.diposeRoundButton
// @public this.dispose = () => { if ( interactionStateProperty.hasListener( interactionStateListener ) ) { interactionStateProperty.unlink( interactionStateListener ); } baseBrighter8.dispose(); baseBrighter7.dispose(); baseBrighter3.dispose(); baseDarker1.dispose(); baseDarker2.dispose(); baseDarker4.dispose(); baseDarker5.dispose(); baseTransparent.dispose(); };
The problem was actually in RoundButton.ThreeDAppearanceStrategy. @jbphet please review, OK to close.
Looks good to me - thanks! Closing.
RoundButton isn't using PhET's
dispose
convention. It's definingdispose
in the constructor. It should be a method that callsthis.diposeRoundButton
.