phetsims / sun

User-interface components for PhET simulations, built on top of Scenery.
MIT License
4 stars 12 forks source link

Dead code in Slider.ts #757

Open pixelzoom opened 2 years ago

pixelzoom commented 2 years ago

@jonathanolson add line 476 in https://github.com/phetsims/sun/commit/d8eaa561bc076cb517d62fa72e70aa530b28a64e, but commented it out. Why?

    // must be after the button is instrumented
476 // assert && assert( !this.isPhetioInstrumented() || this.enabledRangeProperty.isPhetioInstrumented() );
    !ownsEnabledRangeProperty && this.enabledRangeProperty instanceof Property && this.addLinkedElement( this.enabledRangeProperty, {
      tandem: options.tandem.createTandem( 'enabledRangeProperty' )
    } );