search

phetsims / sun

User-interface components for PhET simulations, built on top of Scenery.
MIT License
4 stars 12 forks source link

GroupItemOptions should have value #799

Closed samreid closed 1 year ago

samreid commented 1 year ago

Discovered in https://github.com/phetsims/sun/issues/798, I observed that every usage of GroupItemOptions has a corresponding value of type T. Perhaps it would be appropriate to factor out.

samreid commented 1 year ago

I found this exception 

export type VerticalCheckboxGroupItem = {
  property: Property<boolean>; // Property associated with the checkbox
  options?: CheckboxOptions; // Item-specific options to be passed to the checkbox
} & GroupItemOptions; // additional options that are common to 'group items'

So now I don't think we should do this anymore. Closing