search

phetsims / sun

User-interface components for PhET simulations, built on top of Scenery.
MIT License
4 stars 12 forks source link

Unexpected behavior FlowBox wrap:true inside of Panel #808

Open marlitas opened 1 year ago

marlitas commented 1 year ago

When an HBox with wrap: true is inside of a Panel, the panel is grabbing the minContentWidth of the HBox as though it were already wrapped. This is not passed through or limited by the HBox so the HBox content is overflowing beyond the panel.

Screen Shot 2022-10-28 at 3 20 23 PM
jonathanolson commented 2 months ago

Should be resolved on the layout-2024 branch (scenery/sun so far).

marlitas commented 1 month ago

I'm unassigning and putting on @jonathanolson's plate since it looks like he's actively working on this.

jonathanolson commented 1 month ago

I believe this is fixed up and in main. @marlitas can you verify?

marlitas commented 1 month ago

@jonathanolson I pulled and I'm still seeing it...

image

But I'm also not seeing a commit in sun for this... I'm really confused. Is this work still on a branch?

jonathanolson commented 1 month ago

Looking into it, thought https://github.com/phetsims/sun/commit/177bc5f773ad6b478214617c58f9dde915307ebf was where I resolved it. I'll figure it out.

jonathanolson commented 1 month ago

Ahh, this is blocked by phet-lib not being able to build (due to TypeScript-like changes).

I'll need to rebuild that for it to show up in the layout exemplars (which uses that).

jonathanolson commented 4 weeks ago

Finally figured out the phet-lib build issues. I believe this should be fixed, can you confirm?