Remove unused tandem parameter to createNode

phetsims / sun

User-interface components for PhET simulations, built on top of Scenery.

MIT License

4 stars 12 forks source link

Remove unused tandem parameter to createNode #821

Closed zepumph closed 1 year ago

zepumph commented 1 year ago

From https://github.com/phetsims/sun/issues/797. It seems confusing to have unused parameters in these callbacks:

With TypeScript it is easy to see what the parameter is if we want to use it in the future
There are many spots where the tandemName actually isn't passed through via the tandem, so having the unused tandem var next to tandemName is actually a bit buggy and leading.

zepumph commented 1 year ago

I see 270 usages of tandem => new.

less than a third are used, and about half that I am removing have a tandemName right next to it, from radio button items.

I see 113 usages of tandem => [^n]. About the same results. I like these changes, cleaning things up.

zepumph commented 1 year ago

Most of the weirdness I encountered while working on this issue will be handled in https://github.com/phetsims/sun/issues/822. I'll close this and we can take things up over there. Thanks @jbphet for giving me the strength to make this happen! I'm happy about the change.