phetsims / sun

User-interface components for PhET simulations, built on top of Scenery.
http://scenerystack.org/
MIT License
5 stars 12 forks source link

Confusion around createNode( tandem ) and tandemName #822

Open zepumph opened 1 year ago

zepumph commented 1 year ago

From https://github.com/phetsims/sun/issues/821, is a weird discrepancy going on with GroupItemOptions depending on how the items-based class implements things.

Work for this issue:

I wasn't in the initial GroupItemOptions work, so I'm implicating someone that was (thanks @samreid)

zepumph commented 1 year ago

From https://github.com/phetsims/sun/issues/797#issuecomment-1382565726:

Removing unused tandem parameters made me realize that there is a bit of weirdness about how createNode provided a tandem. In many cases, the tandemName is used by a container of the createNode Node, and shouldn't be used. For example in https://github.com/phetsims/calculus-grapher/blob/b4483f1d83e27508b50bec00cf802d759a31019f/js/common/view/PredictModeRadioButtonGroup.ts#L55-L56. This makes things weird! Let's talk more.

samreid commented 1 year ago

Tagging for https://github.com/phetsims/phet-io/issues/1914 and self-unassigning.