search

phetsims / sun

User-interface components for PhET simulations, built on top of Scenery.
MIT License
4 stars 12 forks source link

Add onInputEmitter to AquaRadioButton(Group) #840

Closed zepumph closed 1 year ago

zepumph commented 1 year ago

Like https://github.com/phetsims/sun/issues/839 and from https://github.com/phetsims/sun/issues/701. We will want this in number play over in https://github.com/phetsims/number-suite-common/issues/56 and https://github.com/phetsims/number-suite-common/issues/47.

zepumph commented 1 year ago

Alright. Again, a very simple commit that will help us out dearly in number-suite. @jessegreenberg, can you spot check this too?

jessegreenberg commented 1 year ago

Here is the commit: https://github.com/phetsims/sun/commit/a3906a678f90f5656030e5cf44a4a28d54cb101d (message just points to #839).

Looking good! A small behavioral change was introduced, sound used to fire on every press instead of on successful Property change. Otherwise the changes to AquaRadioButton and AquaRadioButtonGroup look right.