phetsims / sun

User-interface components for PhET simulations, built on top of Scenery.
MIT License
4 stars 12 forks source link

ComboBox stretching is buggy #849

Open pixelzoom opened 1 year ago

pixelzoom commented 1 year ago

ComboBox layout is currently buggy when stretched.

For example, in Kepler's Laws, TargetOrbitsComboBox implements this combobox:

screenshot_2666

The designer would like to stretch the combobox to fill the width of the panel. Adding this to default options for TargetOrbitsComboBox:

      layoutOptions: {
        stretch: true
      },

... gets us partway there:

screenshot_2664

But the above layout is buggy. Specifically:

Assigning to @jonathanolson, since he recently revised the layout for ComboBox.

For the requirement in Kepler's Law, I advised @AgustinVallejo to push back on the design requirement. So @DianaTavares (the designer) decision on whether this is required will determine the priority of this issue, and whether it's blocking.

DianaTavares commented 1 year ago

I don't love how it looks, but it is functional. For Kepler, then it is ok if the combo box is centered and doesn't follow my design.