search

phetsims / sun

User-interface components for PhET simulations, built on top of Scenery.
http://scenerystack.org/
MIT License
5 stars 12 forks source link

Can ComboBox get better tests? #867

Closed zepumph closed 10 months ago

zepumph commented 10 months ago

There were multiple bugs that came in related to PhET-iO + other features of Combo box (alt input and sound).

https://github.com/phetsims/sun/issues/859 https://github.com/phetsims/sun/issues/861 https://github.com/phetsims/sun/issues/862 https://github.com/phetsims/sun/issues/864

I would like to spend a few minutes trying to brainstorm how we may be able to write tests to help catch this kind of thing for our common code moving forward. @samreid, I'm implicating you for a 15 minute brainstorm (sorry).

This is also coming from https://github.com/phetsims/phet-io-wrappers/issues/632

zepumph commented 10 months ago

@samreid and I discussed this, and determined that we should focus on https://github.com/phetsims/phet-io/issues/1889 and ensuring that QA and devs are well set up to know important things to test, especially as new things come up like this. Closing