jbphet
commented
6 months ago The following patch makes the problem go away. I'm not suggesting this as a fix, just further demonstrating the nature of the problem and showing that it really is related to numeric string lengths.
```diff
Subject: [PATCH] experimental patch for "invalid entry" problem
---
Index: js/accessibility/pdom/ParallelDOM.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/js/accessibility/pdom/ParallelDOM.ts b/js/accessibility/pdom/ParallelDOM.ts
--- a/js/accessibility/pdom/ParallelDOM.ts (revision b1cdc5afbd6763c9a74e4ba5126554253dfd4799)
+++ b/js/accessibility/pdom/ParallelDOM.ts (date 1707245481735)
@@ -2461,6 +2461,16 @@
assert && providedOptions && assert( Object.getPrototypeOf( providedOptions ) === Object.prototype,
'Extra prototype on pdomAttribute options object is a code smell' );
+ if ( typeof value === 'number' && value.toString().length > 10 ) {
+
+ // Limit precision to prevent weird behavior.
+ console.log( '--------------------' );
+ console.log( `attribute = ${attribute}` );
+ console.log( `value (before mod) = ${value}` );
+ value = value.toPrecision( 8 );
+ console.log( `value (after mod) = ${value}` );
+ }
+
const options = optionize()( {
// {string|null} - If non-null, will set the attribute with the specified namespace. This can be required
```
pixelzoom
jessegreenberg
In https://github.com/phetsims/greenhouse-effect/issues/388 it was reported that Firefox and NVDA on Windows was sometimes saying "invalid entry" as part of its description of a slider. I tracked this down to a long string for a numeric value being present in the PDOM, specifically for the
stepvalue, and when the length of the string was reduced the problem went away. This is essentially a workaround for a problem in Firefox, and we should consider reporting the problem to them.In the process of exploring this I found that it was not specific to Greenhouse Effect. I was able to duplicate the issue on the published version of Fourier: Making Waves when navigating to the 3 lower sliders on the "Wave Packet" screen. Changing the length of the
stepvalue did not fix the problem in Fourier, but inspection with the Firefox developer tools indicates several other long strings. Here's a screenshot:I suspect that limiting the length of some or all of these values will stop NVDA from saying "invalid value".
For reference, Firefox version is 122.0.1, NVDA 2023.3.3, Fourier 1.0.17, OS is Windows 11.