search

phetsims / sun

User-interface components for PhET simulations, built on top of Scenery.
MIT License
4 stars 12 forks source link

Should sliders support WASD keys? #876

Open samreid opened 5 months ago

samreid commented 5 months ago

In https://github.com/phetsims/projectile-data-lab/issues/235#issuecomment-1985878860 @catherinecarter noted that for the angle stabilizer slider:

The left/right arrows are working well, the WASD keys are not working.

@matthew-blackman and I tested another simulation and saw that WASD was not a supported input modality for sliders. Should it be? @terracoda and @jessegreenberg what do you think?

catherinecarter commented 5 months ago

For context, the reason I brought it up is because it's in the keyboard help dialog as an option.

samreid commented 5 months ago

Are you referring to this part?

image
samreid commented 5 months ago

Please note I later added this section:

https://github.com/phetsims/projectile-data-lab/issues/235#issuecomment-1986417156

jessegreenberg commented 5 months ago

No, I don't think so. The slider UI component doesn't typically support WASD keys. @catherinecarter does the additional section in https://github.com/phetsims/sun/issues/876#issuecomment-1986417586 resolve your concern?