phetsims / sun

User-interface components for PhET simulations, built on top of Scenery.
MIT License
4 stars 12 forks source link

PhET-iO: too many instrumented containers #888

Open zepumph opened 4 weeks ago

zepumph commented 4 weeks ago

Over in https://github.com/phetsims/density-buoyancy-common/issues/251 @samreid @AgustinVallejo and I would have liked to have been able to provide a tandem to ToggleNode just for its group items, and not instrument the ToggleNode class parent. This is not supported here, and not supported generally. This pattern often leaves a lot of extra and unnecessary instrumentation in published sims, like NodeIO instances.

We think this may be the biggest problem for common code that uses getGroupItemNodes because that pattern is prone to needing the group items instrumented at the cost of instrumenting the parent.