search

phetsims / sun

User-interface components for PhET simulations, built on top of Scenery.
MIT License
4 stars 12 forks source link

ComboBoxButton shrinks as locale is changed. #889

Open pixelzoom opened 1 month ago

pixelzoom commented 1 month ago

This is a (new?) problem with ComboBox, and I'm seeing it in all sims. As locale is changed, the ComboBoxButton gets progressively smaller. I'm seeing this in main with balancing-chemical-equations, beers-law-lab, geometric-optics, ph-scale, ...

To demonstrate in balancing-chemical-equations:

  1. From phetmarks, run http://localhost:8080/balancing-chemical-equations/balancing-chemical-equations_en.html?brand=phet&ea&debugger&locales=*
  2. Got to the Intro screen.
  3. Open Preferences > Localization. Note the size of the Tools combobox in the upper-right corner of the screen:
screenshot_3442



  1. Select each Locale in order, starting from "Afaan Oromoo". Note that the ComboBoxButton gets progressively smaller. By the time you select "English" from the Localization tab, the combobox will look like this:
    screenshot_3440



  2. Keep selecting locales and the ComboBoxButton will continue to get smaller:
screenshot_3441
jonathanolson commented 1 month ago

Fixed in the commit above. @pixelzoom can you verify?

marlitas commented 1 month ago

I confirmed this is now working on the local version of MSaB.

samreid commented 1 month ago

@marlitas confirmed it does not need a maintenance release. @marlitas reviewed the proposed solution and it seems good.

pixelzoom commented 1 month ago

Tested in BCE and this appears to be fixed in main.

Comments above indicate that an MR is needed, so assigning to @jonathanolson.