search

phetsims / sun

User-interface components for PhET simulations, built on top of Scenery.
http://scenerystack.org/
MIT License
5 stars 12 forks source link

Panels should put helpText above their content #912

Closed jessegreenberg closed 2 weeks ago

jessegreenberg commented 2 weeks ago

From https://github.com/phetsims/models-of-the-hydrogen-atom/issues/79. There was a request for helpText for a panel of content. It came after the accessible content in the panel. helpText should come before content for panels.

We recently did this too for AccordionBox. Consider other components where helpText should come before content.

jessegreenberg commented 2 weeks ago

Done for Panel. I scanned through components in sun and scenery-phet looking for other Nodes that hold content like this. I found these related components

AccordionBox and Dialog were recently handled in https://github.com/phetsims/sun/issues/905 and https://github.com/phetsims/sun/issues/902.

Drawer will need its own implementation for accessibleName, helpText, and alt input so we will handle this when we reach that component.

BackgroundNode is a visual decoration and does not need this.

Closing.