Closed pixelzoom closed 4 months ago
I've implemented this change for ContinuousPropertySoundClip
, and changed the usages in sims such that they all use the default stepEmitter
and thus don't have to step the ContinuousPropertySoundClip
explicitly in the client code. Seems like a nice improvement.
This is the only sound generator with a step function like this in tambo, so I think this is done. I'll try to make sure to follow this pattern in the future.
@pixelzoom - can you please review the changes? You can ignore the commit to WaterBalanceSoundGenerator
- that shouldn't have been included as part of this.
Changes for stepEmitter
option look good. Back to @jbphet in case there's more work to do, feel free to close.
ContinuousPropertySoundClip
is an example of a sound that needs to be stepped. Thestep
method is "used for fading out the sound in the absence of change."Having to call
step
can be very inconvenient, and problematic if sound needs to continue while the sim is paused.The
stepTimer
option found in twixt.Animation provides an alternative (albeit with problems of its own) to having to manually callstep
:... and FELSonifier:
Assigning to @jbphet so we can discuss/triage today.