search

phetsims / tambo

library containing code to support sonification of PhET simulations
http://scenerystack.org/
MIT License
2 stars 4 forks source link

LoL sound continues after pause #98

Open KatieWoe opened 5 years ago

KatieWoe commented 5 years ago

For https://github.com/phetsims/QA/issues/277 The sounds in the Graphing Lines game do not pause when the legends of learning harness is paused. Likely to be deferred as in https://github.com/phetsims/fractions-common/issues/80.

pixelzoom commented 5 years ago

Is this the "cheering" game reward sound?

KatieWoe commented 5 years ago

Most noticeable, as it is the longest. Happens with the other sounds as well though, such as the "ding you got it right" sound.

pixelzoom commented 5 years ago

Questions:

@jbphet: There's currently no API for pausing these sounds. Is that supported in the new sonification sound API?

@arouinfar @ariel-phet @samreid I was under the impression that there was nothing that needs to be changed in a sim to make it work for LoL. Is LoL expecting to use some API (PhET-iO?) to pause sound?

arouinfar commented 5 years ago

I feel like I've seen some iteration of this same issue pop up for just about every sound-containing sim being tested in the LoL harness. @KatieWoe has there been an related issue in a common repo?

@pixelzoom you may find https://github.com/phetsims/resistance-in-a-wire/issues/194#issuecomment-460123581 helpful. I don't really know anything about the technical aspects of LoL support.

In the LoL environment, the teacher has the option to pause the activity for all students, most likely for a quick announcement or class discussion. John Travoltage (which has sonification) has been integrated into LoL, so it seemed like an easy candidate to test this sort of issue "in the wild" (given that it makes quite a bit of sound). I created a dummy activity on my teacher account, and opened it in another browser on my student account. When a teacher pauses the activity, the students see an LoL splash page, but any sound that was playing when the teacher paused the activity could still be heard.

image

samreid commented 5 years ago

We already discussed this problem and proposed a solution in https://github.com/phetsims/tambo/issues/51

pixelzoom commented 5 years ago

But that solution assumes that the sim is using tambo, correct? This sim is still using vibe.

samreid commented 5 years ago

That issue is for tambo. https://github.com/phetsims/vibe/issues/33 is for rewriting vibe to use tambo.

Correct me if I'm wrong, but if vibe only supports pre-recorded samples, and not long-running dynamically generated sound, then it is probably fine if the sound continues after pause is pressed. It will stop shortly thereafter when the sound is done.

@KatieWoe's original note:

Likely to be deferred as in phetsims/fractions-common#80.

Seems appropriate to me.

pixelzoom commented 5 years ago

Or perhaps we should close this and other sim-specific issues that identify this as a "bug", and formulate a plan based on phetsims/vibe#33 (porting to tambo) and phetsims/tambo#51 (handling pause in tambo).

pixelzoom commented 5 years ago

@amanda-phet @ariel-phet does this need to be addressed for the current RC, or can it be deferred until we have a general plan? (See https://github.com/phetsims/tambo/issues/57.)

ariel-phet commented 5 years ago

@pixelzoom does not need to be addressed for current RC

pixelzoom commented 4 years ago

This issues is not specific to graphing-lines, and still occurs now that this sim is using tambo for sound. So transferring this issue to tambo.