Closed samreid closed 1 year ago
Ok, trying to get a handle on this issue:
][,-
) or if it is just out of syncconst regexBaseCharsAllowed = 'A-z0-9. . . '
; And then we use new RegExp()
to fill it in, or add the _
in dynamic tandem.Adding to the PhET-iO backlog over in https://github.com/phetsims/phet-io/issues/1914
Looking great, thanks! @zepumph also volunteered to put some RegExp constants nearby Tandem.BASE_TANDEM_TERM
.
Thanks for helping me get this. I like where we got it.
More generally, there is copy/paste duplication and inconsistency between all of the regexes for
isValidTandemName
. Should we create our own data structure to make it possible to "tack on" more allowed characters for certain cases?Also note: DynamicTandem doesn't allow commas. That is a problem too.