search

phetsims / tandem

Simulation-side code for PhET-iO
MIT License
0 stars 5 forks source link

Primitive IOTypes should have much less boilerplate #280

Closed zepumph closed 1 year ago

zepumph commented 1 year ago

Over in #277 @samreid and I realized that we should just simplify types and state objects for number, string, and boolean, instead of continuing to build up scaffolding for them. More to explain later!

zepumph commented 1 year ago

@samreid and I made a bunch of progress here. We realized how much less work it is to have BooleanIO StringIO and NumberIO serialize as their primitives. The only reason we hadn't done that yet is because NumberIO was serializing infinity for us. What a headache infinity was causing. So we just made it its own IOType. Only needed by RangeIO and Bounds2IO. So much nicer! This will be some API changes though, I wonder if we need some migration rules for it! Commit coming soon.

zepumph commented 1 year ago

@samreid can you please review this and https://github.com/phetsims/tandem/issues/277#issuecomment-1289804145 and let me know if you think there is anything more to do?

zepumph commented 1 year ago
zepumph commented 1 year ago

@samreid sorry I didn't assign you.

zepumph commented 1 year ago

@samreid sorry I didn't assign you.

And still! :sigh:

samreid commented 1 year ago

I updated the docs, skimmed commits and reviewed comments. Everything seems great! Closing.