Autoselect target follows linked elements recursively (is that good?)

[samreid]

While working on https://github.com/phetsims/center-and-variability/commit/f2941dc88774d5274cb83bc9ef8722dae0748184 in https://github.com/phetsims/center-and-variability/issues/204 I saw there were 2 levels of linked elements. The cardNode => cardModel => soccerBallModel. The value is changed on the soccer ball model. I incorrectly thought autoselecting linked element on the cardNode would autoselect to the cardModel, but it ended up all the way at soccerBallModel. @zepumph is this all good?

UPDATE: In this case it's probably OK since all of the important data is over in soccerBallModel. But some other sim may have important data in the cardModel layer itself.

[zepumph]

I agree. How does this sound?

[zepumph]

I am considering this a bug fix for the original implementation of sim-side autoselect over in https://github.com/phetsims/studio/issues/304

[samreid]

I reviewed the commit and confirmed it works well in center and variability. Some questions:

• Is there a better way to name fromLinking? I couldn't think of one, but just wondering if that could help maintainability.
• I noticed there are overrides of getPhetioMouseHitTarget that do not provide the fromLinking parameter. For instance, in ReadOnlyProperty. Don't all subclasses need to be aware of this parameter and pass it to super?

[zepumph]

Nice catch. To understand better, I was able to create a failing unit test that showed how we could still recurse into a Text.stringProperty if in linking selection mode. Anything else here?

I can't think of a better name than fromLinking want to think about something else?

[samreid]

Excellent, thanks! Looks good, closing.