search

phetsims / tandem

Simulation-side code for PhET-iO
MIT License
0 stars 5 forks source link

LinkedElement should hide most PhetioObjectOptions #301

Closed zepumph closed 1 year ago

zepumph commented 1 year ago

Today while working on https://github.com/phetsims/studio/issues/309, @samreid and @pixelzoom and I decided that we liked not allowing most options as LinkedElementOptions. let's tighten this API up a bit to prevent confusion.

zepumph commented 1 year ago

@pixelzoom, can you please review. I found some phetioDocumentation being provided in calculus grapher, and moved it to the core element. Notice that not all properties created with createYProperty have phetio doc, do you want to update all of them for consistency? Up to you. I'm ready to close if you are.

pixelzoom commented 1 year ago

I found some phetioDocumentation being provided in calculus grapher, and moved it to the core element.

Most of this phetioDocumentation didn't make much sense in the new context, and there were typos introduced. Fixed in the above commits.

Everything else looks great, thanks. Closing.