phetsims / tasks

General tasks for PhET that will be tracked on Github
MIT License
5 stars 2 forks source link

Remove support for IE11 #1037

Open zepumph opened 4 years ago

zepumph commented 4 years ago

Today we decided to remove support of IE11. Wahoo!

We will want to do the following work:

We can continue to add to this list during dev meeting discussion

chrisklus commented 4 years ago

from 06/18/20 dev meeting:

One part we brought up is that it would be nice for us to use built-in versions of utility functions like String.endsWith and Array.includes instead of the lodash versions going forward.

For now, we're not going to replace existing lodash usages that have built-in counterparts, but will keep that big shift as an option for the future if we find it annoying that there's occurrences of both.

As a general rule for IE workarounds, @ariel-phet says feel free to remove anything that's in the way or annoying, but no need to carefully go through and remove stuff that's not intrusive.

mattpen commented 4 years ago

Dev meeting, 7/30: @zepumph will continue to chip away as time allows, but nothing is time sensitive.

Urgent problems have separate issues, like phetsims/chipper#963

zepumph commented 3 years ago

I did a bit of work here, largely removing the IE specific code in phet-io. It simplified implementations, and cleaned things up. In general I think this is time well spent. I am not going any further for now. Let's bring this back to dev meeting to see if we should keep chipping away, or just close with IE-specific code in our code-base for ever.

Denz1994 commented 3 years ago

From dev meeting on 11/23/20:

MK: I worked on the most important pieces from the original checklist.

MK: We should add an item to the CRC that says "IE isn't supported and shouldn't require workarounds".

JO: I can remove any Scenery workarounds, but will have to review the instances.

@samreid will take a pass of the easy items remaining (removing IE preload polyfills). Note: These aren't critical to the project but if it isn't too much to handle the remaining items we should do so.

@jonathanolson will take a pass at any Scenery workarounds and remove them.

samreid commented 3 years ago

I addressed several parts in the commits above. I did not want to take the time to convert all string.indexOf to string.includes or string.startsWith, so I added that to the CRC. The remaining work for this issue is:

Leaving assigned to @jonathanolson for these final steps.