search

phetsims / tasks

General tasks for PhET that will be tracked on Github
MIT License
5 stars 2 forks source link

Rename "Self Voicing" to "Voicing" throughout the project #1083

Closed jessegreenberg closed 3 years ago

jessegreenberg commented 3 years ago

We are renaming the "Self-Voicing" feature to "Voicing". The "Self" was to distinguish from other types of speech output like screen-reader software. But that only makes sense to those within the project that work on both features. "Voicing" is more simple and is a better public facing name fore the feature. Issue will track renaming commits.

jessegreenberg commented 3 years ago

Rename was done for documentation and class names. I don't see any hits for 'selfvoicing', 'self-voicing' or 'self voicing' in the project. Sims are running well in local aqua. Closing.

zepumph commented 3 years ago

I just checked out preferences branches in joist, sun, and friction and found them un-runnable because this rename wasn't propagated there. I'm not sure if that was purposeful or expected, so I'll just pass it to @jessegreenberg to decide, as they are his branches and I'm unsure about their future.

jessegreenberg commented 3 years ago

Thanks @zepumph, "self-voicing" removed from new classes in preferences branch.