phetsims / tasks

General tasks for PhET that will be tracked on Github
MIT License
5 stars 2 forks source link

Using pull requests in PhET development #1086

Open pixelzoom opened 3 years ago

pixelzoom commented 3 years ago

The topic of pull requests has come up a few times in the context of https://github.com/phetsims/tasks/issues/1084, where @oliver-phet pointed out that the PhET iOS app team uses pull requests to organize their work, and pull requests might be useful for creating changelogs.

A pull request is essentially a merge request. Work is done on a branch. When the work is completed, the developer makes a pull request, which results in a review of the work. When the review passes, the work is merged into another branch (master, the production branch, a release branch,...)

From 5/27/21 developer meeting: The consensus was that this would be a very different way of working for PhET, but potential more typical of software development with larger teams. We are unclear about the pros/cons.

The next step will be for @oliver-phet to arrange for the PhET iOS app team to give a brief presentation on how they are using pull requests, at a future developer meeting