phetsims / tasks

General tasks for PhET that will be tracked on Github
MIT License
5 stars 2 forks source link

Standardize labels for GitHub issues #465

Closed phet-steele closed 8 years ago

phet-steele commented 8 years ago

Make all the labels across sim repos and tasks the same color and text.

mattpen commented 8 years ago

Discussed with @ariel-phet in a Skype call. One possible solution is pushing the new labels but not removing the old labels, then having @phet-steele or another QA person manually adjust any duplicate labels in the repos with a large issue history.

pixelzoom commented 8 years ago

Feedback on https://github.com/phetsims/tasks/issues/465#issuecomment-178958530

The "priority" group names look a little off. There are 5 different groups: "priority1",...,"priority5". Did you mean for all of these to be "priority"?

samreid commented 8 years ago

The "priority" group labels look a little off. There are 5 different groups: "priority1",...,"priority5". Did you mean for all of these to be "priority"?

I am guessing he did that so the alphabetical sorting would match the priority ranking. Correct me if wrong!

ariel-phet commented 8 years ago

@pixelzoom yes see https://github.com/phetsims/tasks/issues/465#issuecomment-178962478

Don't have to stick with that, but I found it useful when testing out creating an issue

pixelzoom commented 8 years ago

Recommended to use 1 group name, and move the sorting issue to the name. Ie:

priority:1-top priority:2-high priority:3-medium priority:4-low priority:5-deferred

jonathanolson commented 8 years ago

Recommended to use 1 group name

Sounds beneficial long-term to me.

ariel-phet commented 8 years ago

That works for me, will adjust

samreid commented 8 years ago

Looks great, nice suggestion @pixelzoom

mattpen commented 8 years ago

Discussed at dev meeting on 2/4/2016. I'm going to extract the JSON for expression exchange label state and store in phet-info. I'll also test pushing the new labels to the masses-and-springs repo.

mattpen commented 8 years ago

I pushed the new labels to masses-and-springs tonight. Should we automatically replace the github standard-issue labels? e.g 'bug' becomes 'type:bug'

phet-steele commented 8 years ago

Should we automatically replace the github standard-issue labels?

@mattpen no. In fact we will be doing the opposite. It will be a manual task of going through and editing the standard labels to match the new names, then deleting the new labels. We want to preserve the standard labels so any issue with a preexisting label assigned to it will not have its label deleted.

mattpen commented 8 years ago

@phet-steele The reason we're not doing this automatically is because there are too many variations on user-created labels. I'm just suggesting we update the 6-7 automatically issued labels, not delete and replace. It would be the same thing you are doing, just in a script.

This would just be for the standard labels, e.g bug, invalid, help wanted, not any PhET specific labels.

phet-steele commented 8 years ago

Oh now that does sound nifty @mattpen! Thoughts @ariel-phet? We should at least test this script, probably in the masses-and-springs repo at this point, with an issue that has a standard label and see if the label is removed after running the script.

mattpen commented 8 years ago

To clarify, I'm only referring to these labels: image

phet-steele commented 8 years ago

@mattpen I know :smile:

mattpen commented 8 years ago

The script and standard codes in JSON format are here

ariel-phet commented 8 years ago

@mattpen yes, I think it would be safe to replace the standard github labels

ariel-phet commented 8 years ago

And obviously the "invalid" label can just be deleted

mattpen commented 8 years ago

Masses and Springs shows the results after running the script I wrote.

@ariel-phet, Is there another repo you want to test this on?

ariel-phet commented 8 years ago

@mattpen please try on Friction

If everything works as planned, I would expect the Summer Redeploy label to remain

mattpen commented 8 years ago

@ariel-phet I just ran the script for friction, please check at https://github.com/phetsims/friction/labels

ariel-phet commented 8 years ago

Working as expected. Lets run on all repos. Once complete reassign to me.

mattpen commented 8 years ago

The new labels have been added to all 119 repos. I checked a few and it looks like it worked as planned.

ariel-phet commented 8 years ago

All repos have been double checked and de-duplicated. Closing