phetsims / tasks

General tasks for PhET that will be tracked on Github
MIT License
5 stars 2 forks source link

Verify that dispose functions are named correctly for all types #727

Closed jessegreenberg closed 7 years ago

jessegreenberg commented 7 years ago

From https://github.com/phetsims/sun/issues/212 it was clear that dispose functions are being named without consistency.

The dispose function should be named such that the 'MyType' should have a dispose function that matches 'disposeMyType' exactly.

jessegreenberg commented 7 years ago

In a search, I found that the following repositories have dispose functions that break this convention:

jessegreenberg commented 7 years ago

That should be all of them. Closing.