search

phetsims / trig-tour

"Trig Tour" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/trig-tour
GNU General Public License v3.0
2 stars 2 forks source link

Equals sign bleeds into 'angle' on ReadoutNode #58

Closed jessegreenberg closed 9 years ago

jessegreenberg commented 9 years ago

Noticed while testing sim performance on iPad2. The equals sign bleeds into the 'angle' text on iPad2, Safari iOS 8.2.

img_0040

jessegreenberg commented 9 years ago

Was hoping that #46 would resolve this, but no luck. The issue occurs intermittently for ipad2 iOS 8.2. I will see if I can reproduce in safari on other platforms.

jessegreenberg commented 9 years ago

Reproduced this issue with Curie, so this looks like a Safari issue. Fixed in the commit above, '=' and 'angle' are separated in their own text nodes .

I believe that this has something to do with concatenating translatable strings in the .json file. Using hard coded strings 'angle' + '=' and 'angle = ' also solved the problem. But concatenating strings out of the tirg-tour-strings_en.json caused the weird text rendering in Safari. Closing this issue but moving to scenery to bring to the attention of other developers.