search

phetsims / twixt

Animation library for interactive HTML5 graphics
MIT License
1 stars 3 forks source link

Animation emitters have different tenses #13

Open samreid opened 6 years ago

samreid commented 6 years ago

From #11

The emitters are:

    this.startEmitter = new Emitter();
    this.beginEmitter = new Emitter();
    this.finishEmitter = new Emitter();
    this.stopEmitter = new Emitter();
    this.endedEmitter = new Emitter();
    this.updateEmitter = new Emitter();

Perhaps we should rename endedEmitter => endEmitter unless there is a good reason for the inconsistency?

pixelzoom commented 6 years ago

+1 to rename endedEmitter => endEmitter.