search

phetsims / twixt

Animation library for interactive HTML5 graphics
MIT License
1 stars 3 forks source link

SlidingScreen should have a dispose function that unlinks #7

Closed samreid closed 6 years ago

samreid commented 6 years ago

SlidingScreen links to properties on creation, its dispose function should unlink.

Discovered in https://github.com/phetsims/area-model-common/issues/99

jonathanolson commented 6 years ago

So I hate to do this so quickly, but should be deprecate SlidingScreen in favor of TransitionNode (particularly once it is reviewed/etc.)?

samreid commented 6 years ago

We should proceed with #10, I'll unassign myself and put this issue on hold until then.

pixelzoom commented 6 years ago

This issue is no longer relevant, since SlidingScreen is deprecated and replaced by TransitionNode (which has a dispose function). Closing.