search

phetsims / under-pressure

"Under Pressure" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/under-pressure
GNU General Public License v3.0
0 stars 4 forks source link

Move leftDisplacement from UnderPressureModel to ChamberPoolModel #101

Closed samreid closed 10 years ago

samreid commented 10 years ago

During the code review #88, @jbphet & I noticed this line in UnderPressureModel:

leftDisplacement: 0, //displacement from default height, for chamber-pool

This should be moved to ChamberPoolModel.js, into the PropertySet call:

PropertySet.call( this, { stackMass: 0 } );
notsiddhartha commented 10 years ago

Fixed above. Assigning to @samreid for review.

samreid commented 10 years ago

Looks good, thanks! Closing.