search

phetsims / under-pressure

"Under Pressure" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/under-pressure
GNU General Public License v3.0
0 stars 4 forks source link

Properties should have `Property` suffix #119

Closed pixelzoom closed 9 years ago

pixelzoom commented 9 years ago

Examples of anti pattern:

MysteryPoolModel: this.fluidDensityCustom = new Property( 0 ); MysteryPoolModel: this.gravityCustom = new Property( 0 );

pixelzoom commented 9 years ago

Assigning to @jbphet since he's the liaison.

jbphet commented 9 years ago

I've changed the two properties called out above to be customFluidDensityProperty and customGravityProperty. I don't see any other individually declared properties in the sim code, so I think this issue is now addressed. Assigning back to @pixelzoom for final verification.

pixelzoom commented 9 years ago

:+1: Closing.