search

phetsims / under-pressure

"Under Pressure" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/under-pressure
GNU General Public License v3.0
0 stars 4 forks source link

sim relies on align:'right' default for Panels #143

Closed pixelzoom closed 8 years ago

pixelzoom commented 8 years ago

Related to https://github.com/phetsims/sun/issues/252, this sim uses Panel option minWidth and relies on the old default of align:'right' for Panels. Below are the stack traces for occurrences that need to be checked. These are the occurrences noted when loading the sim in requirejs mode. If the sim creates Panels dynamically, you should do further checking with fuzzMouse.

>>>> sim relies on align:right
VM30284 Panel.js?bust=1472165070055:54 Error
    at ControlPanel.Panel [as constructor] (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472165070055:50:15)
    at new ControlPanel (http://localhost/~cmalley/GitHub/fluid-pressure-and-flow/js/under-pressure/view/ControlPanel.js?bust=1472165070055:85:11)
    at new UnderPressureView (http://localhost/~cmalley/GitHub/fluid-pressure-and-flow/js/under-pressure/view/UnderPressureView.js?bust=1472165070055:82:24)
    at UnderPressureScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/fluid-pressure-and-flow/js/under-pressure/UnderPressureScreen.js?bust=1472165070055:29:34)
    at UnderPressureScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472165070055:134:25)
    at UnderPressureScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472165070055:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472165070055:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472165070055:439:13)
    at http://localhost/~cmalley/GitHub/under-pressure/js/under-pressure-main.js?bust=1472165070055:35:15
pixelzoom commented 8 years ago

I believe that this sim may be a subset of FPAF, so this may be a duplicate of https://github.com/phetsims/fluid-pressure-and-flow/issues/291.

pixelzoom commented 8 years ago

No problem, in fact an improvement. The top panel in the screenshot below shifted left one pixel, and is now properly aligned with the panel below it:

screenshot_91

@samreid Please review if you'd like.

samreid commented 8 years ago

It seems good for now, closing.