search

phetsims / unit-rates

"Unit Rates" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 2 forks source link

marker editor doesn't move immediately to 'home' position on Reset All #169

Closed pixelzoom closed 7 years ago

pixelzoom commented 7 years ago

If you push the 'Reset All' button in a scenario like this:

screenshot_170

... the marker editor will animate back to its home position (left of the double number line), rather than move there immediately. This is because the marker location is handled in the view using TWEEN. This could be changed, but it involves either (a) adding complicated code to cancel the TWEEN animation, or (b) replacing TWEEN with animation in the model. Since this seems generally unnecessary, I'm inclined to do neither, and just note the decision in this issue.

@arouinfar If you disagree, let me know and I'll try to address this. Otherwise please close.

arouinfar commented 7 years ago

Thanks for letting me know @pixelzoom. I don't think this is anything we need to be worried about.