search

phetsims / unit-rates

"Unit Rates" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 2 forks source link

dispose of ShoppingSceneNode when switching categories #178

Closed pixelzoom closed 7 years ago

pixelzoom commented 7 years ago

Currently, each category keeps its most recent ShoppingSceneNode. So switching between categories doesn't result in disposal of a ShoppingSceneNode. @Denz1994 found this a bit confusing, and recommended (for consistency) to handle dispose uniformly.

pixelzoom commented 7 years ago

https://github.com/phetsims/unit-rates/issues/159

pixelzoom commented 7 years ago

This will make the performance of switching categories the same as switching items. And it should make Reset All slightly more responsive on iPad (where it's already under 1 sec.)

pixelzoom commented 7 years ago

After investigating, I decided that I'm not going to do this. It would either (a) also involve disposing of the combo boxes, or (b) require non-trivial changes to how the top-level view is structured. And I don't think that those changes are worth the small advantages in consistency.