Closed phet-steele closed 7 years ago
@phet-steele good observation. I find it a little odd, but not bothersome.
Perhaps there could be a separate common code issue to look into the difference in appearance, and perhaps address it? I don't think it's a high priority issue, but I still think it would be good to look into it, as time allows.
@phet-steele can you create an issue about the checkmark appearance in the appropriate common code repo?
Curious...
The checkmark is a Unicode character ('\u2713'
, "heavy-ballot check mark") that is rendered with scenery-scenery.ShadowText
, with font family 'Arial'
. Here's the code in ShoppingQuestionNode:
// check mark to right of box, to indicate that the question has been correctly answered
var checkMarkNode = new ShadowText( '\u2713', {
fill: URColors.checkMark,
font: new URFont( 36 ),
...
} );
But it appear to be rendered in a different font on iOS.
@jonathanolson Any insights?
The checkmark is a Unicode character ('\u2713') that is rendered with scenery-scenery.ShadowText, with font family 'Arial'.
Doesn't look like the Mac version of Arial on my MBP specifies the question mark, probably falls back to the default "sans-serif" system font per platform.
If a consistent appearance is desired, font-awesome could be used?
@arouinfar Is the font-awesome check marker acceptable? http://fontawesome.io/icon/check/
In context (I can investigate whether there's a version without the box):
Here's the font-awesome check mark without the box. I don't think it would benefit from a drop shadow. @arouinfar is this acceptable?
Other sims that use the Unicode check mark ('\u2713'), and should also be fixed:
balancing-chemical-equations graphing-lines
@pixelzoom I like the checkmark in https://github.com/phetsims/unit-rates/issues/180#issuecomment-285182113. As for the drop shadow, I could take it or leave it.
Since this will effect more than Unit Rates, I'd like to for @ariel-phet and/or @amanda-phet to also review.
I think the other sims also have an incorrect "x", so if we made a universal change we'd want to consider how that would look we well.
The default sans-serif in iOS doesn't bother me, but using fontawesome seems like a good idea.
This is the "x" that we'd probably use:
I think the other sims also have an incorrect "x", so if we made a universal change we'd want to consider how that would look we well.
Believe it or not, the "x" is the same on both platforms. The "x" in question is below and looks the same on iOS vs. macOS 10.12.3, maybe something else is going on here?
Regardless, @amanda-phet is correct in saying that if we change the check mark, that means we should change the "x" as well.
Indeed, those other sims use Unicode "big X" ('\u2718'
) for incorrect. E.g.:
Fontawesome check marks are used in this dev version, if anyone wants to test drive: http://www.colorado.edu/physics/phet/dev/html/unit-rates/1.0.0-dev.69/unit-rates_en.html
The check looks fine to me, and as long as people are OK with the x then we can plan to use those icons in future sims (and sim releases).
I would say the non-font-awesome has a bit more of a "hand drawn feel" so it is really an aesthetic choice. I am fine with either, and I think the meaning is clear with either.
Deferring that decision to @arouinfar since @amanda-phet seems fine with the look
@arouinfar If you're fine with the font-awesome icons (check and X), then assign back to me. I'll create issues to use those icons in balancing-chemical-equations and graphing-lines.
@ariel-phet I would agree that the original (non-iOS) check is a bit more aesthetically pleasing than the font-awesome check. However, I think the advantage of using the font-awesome icons will be that the look is consistent across platforms, which is apparently a failing of the unicode version.
@pixelzoom please proceed with the font-awesome icons.
Implemented for unit-rates in 1.0.0-dev.69. Issues created for other sims. Closing.
...with an entirely different drop shadow to boot. @arouinfar is that okay? The same thing occurs in Balancing Chemical Equations and no one seems to care, but I'm going to mention it anyway.
Expected:
iOS:
For phetsims/tasks/issues/797.