phetsims / unit-rates

"Unit Rates" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 2 forks source link

Query Parameters refactored into sim specific directories. #190

Closed Denz1994 closed 7 years ago

Denz1994 commented 7 years ago

Following this bullet in the code review document:

Are sim-specific query parameters (if any) identified and documented in one .js file in js/common/ or js/ (if there is no common/)? The .js file should be named {{REPO}}QueryParameters, for example ArithmeticQueryParameters for the aritmetic repository.

Currently, all of the query parameters are located in a common directory. Should screen specific query parameters be located in their own directory as suggested below:

CommonQueryParameters:

ShoppingQueryParameters

ShoppingLabQueryParameters

RacingLabQueryParameters

pixelzoom commented 7 years ago

Nope. Read the review item again. Query parameters are encapsulated in 1 file per sim, not per screen. The idea is that team members and testers should have 1 place they need to consult.

Denz1994 commented 7 years ago

Very true. Closing because this is handled correctly.

Denz1994 commented 7 years ago

159