phetsims / unit-rates

"Unit Rates" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

0 stars 2 forks source link

Missing dispose function for derived property? #194

Closed Denz1994 closed 7 years ago

Denz1994 commented 7 years ago

In common\model\DoubleNumberLine.js at the initializaion of this.denominatorRangeProperty (line 84) and this.numeratorRangeProperty on (line 106), it is documented that these properties need disposal.

I cannot find a corresponding disposal call for these properties. Please advise if I am missing something. Thank you.

Denz1994 commented 7 years ago

159

pixelzoom commented 7 years ago

dispose is not needed the for anything in the model, it exists for the lifetime of the sim. The documentation was incorrect, fixed in the above commit. Thanks for catching.

Denz1994 commented 7 years ago

Understood. Thanks for the update. Closing.