search

phetsims / unit-rates

"Unit Rates" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 2 forks source link

publish 1.0.4 #203

Closed pixelzoom closed 6 years ago

pixelzoom commented 6 years ago

1.0.4 is a maintenance release that contains the fix for https://github.com/phetsims/unit-rates/issues/202.

pixelzoom commented 6 years ago

I’m in the middle of publishing maintenance release 1.0.4 for unit-rates, encountering failures due to phetAPIDocs.js during checkout-shas:

% cd unit-rates
% git checkout 1.0
% cd perennial
% grunt checkout-shas --repo=unit-rates
% grunt
Loading "Gruntfile.js" tasks...ERROR
>> Error: Cannot find module 'load-grunt-tasks'
Warning: Task "default" not found. Use --force to continue.

Aborted due to warnings.
% status.sh
....
chipperfatal: ambiguous argument 'origin/phetioAPIDocs...HEAD': unknown revision or path not in the working tree.
...
scenery-phetfatal: ambiguous argument 'origin/dag-movable-drag-handler': unknown revision or path not in the working tree.
...
%

@jonathanolson and @jbphet have done previous maintenance releases on this sim. @jonathanolson did 1.0.1 and 1.0.3, @jbphet did 1.0.2. So I suspect that something is wrong with dependencies.json.

Side notes:

(1) It would also be nice if “status.sh” stopped when encountering a problem like this, instead of continuing. (EDIT: reported in https://github.com/phetsims/perennial/issues/43)

(2) I’m really getting tired of encountering problems every time I try to publish something. Something that should take me 10 minutes is (once again) going to take me an unknown amount of time, involving an unknown number of developers.

pixelzoom commented 6 years ago

@jbphet @jonathanolson tell me about the maintenance releases that you did. Did you leave the 1.0 release branch in a working state?

@jonathanolson The scenery-phet error identifies 'origin/dag-movable-drag-handler'. Ring any bells?

@zepumph @samreid The chipper error identifies 'origin/phetioAPIDocs'. Ring any bells?

pixelzoom commented 6 years ago

I originally identified the error as occurring during grunt checkout-shas, but that was incorrect. grunt fails, and then status.sh indicates that chipper and scenery-phet may have problems. I've edited https://github.com/phetsims/unit-rates/issues/203#issuecomment-336634284 accordingly.

samreid commented 6 years ago

Here's what happened for me, then I was able to launch the requirejs and built versions with no issues. It seems I was using the grunt checkout-shas from the sim repo as described in https://github.com/phetsims/phet-info/blob/master/deployment-info/sim_deployment.md whereas @pixelzoom was using perennial's grunt checkout-shas. Could this explain the difference?

~/github/unit-rates$ git checkout 1.0
Switched to branch '1.0'
Your branch is up-to-date with 'origin/1.0'.

~/github/unit-rates$ git pull
Already up-to-date.

~/github/unit-rates$ grunt checkout-shas
Running "checkout-shas" task
Checking out dependency assert: HEAD@a707328cc11048787a807714496af23e0bd25be1
Checking out dependency axon: HEAD@f7720d0e57be3884aedaa78bd799d1fac8168711
Checking out dependency brand: HEAD@b6bdbc2b7d618f8fbd2851a95476c0eb1205acf5
Checking out dependency chipper: HEAD@2d1b574e80bcf70cbc1ae7ccda6289a51a98875b
Checking out dependency dot: HEAD@569939e1f45973234a3819255a88cd2b80006f76
Checking out dependency joist: HEAD@ab42a2b92849293697db12d3ca148756f5b79dfb
Checking out dependency kite: HEAD@81166ce9735f0bcb11b9e68b74eeed46b6f24da6
Checking out dependency phet-core: HEAD@c5c6c2a8273b9bd3f3bcb4ddfbcf24058b58954a
Checking out dependency phetcommon: HEAD@85801e7b43730588c1e2770fb64d633c58d71759
Checking out dependency query-string-machine: HEAD@d8a4ff18a12aff003e4896213c1dfed5a79c1a30
Checking out dependency scenery: HEAD@4619049e07623c09c616fe8853387a4c8a7bed2a
Checking out dependency scenery-phet: HEAD@6213dc27544de739f31722d59f1a756e20ca03fb
Checking out dependency sherpa: HEAD@3255de0f1edda165ff360076051a56cd31cd3ea5
Checking out dependency sun: HEAD@bffd225eb8be0412385b8c542bcf8edc282fe31d
Checking out dependency tandem: HEAD@a668abd5e2f1d6b80de925c9e7567c4468a34f3a
Checking out dependency twixt: HEAD@a6bd3909751e280b7fdbe2f0ecd9ec066d152ff5

Note: checking out 'a707328cc11048787a807714496af23e0bd25be1'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at a707328... Removed requirejs and uglify from package.json, see https://github.com/phetsims/chipper/issues/538

Finished checkout.

Note: checking out 'b6bdbc2b7d618f8fbd2851a95476c0eb1205acf5'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at b6bdbc2... Include Android app in the isPhetApp check, see https://github.com/phetsims/phet-android-app/issues/16

Finished checkout.

Note: checking out 'd8a4ff18a12aff003e4896213c1dfed5a79c1a30'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at d8a4ff1... Removed requirejs and uglify from package.json, see https://github.com/phetsims/chipper/issues/538

Finished checkout.

Note: checking out 'c5c6c2a8273b9bd3f3bcb4ddfbcf24058b58954a'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at c5c6c2a... More flexible mixin handling, used initially for drag-listener prototypes (https://github.com/phetsims/scenery/issues/131)

Finished checkout.

Note: checking out 'a668abd5e2f1d6b80de925c9e7567c4468a34f3a'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at a668abd... removed ifphetio from imports of common and sim code, https://github.com/phetsims/phet-io/issues/1074

Finished checkout.

Note: checking out 'f7720d0e57be3884aedaa78bd799d1fac8168711'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at f7720d0... removed ifphetio from imports of common and sim code, https://github.com/phetsims/phet-io/issues/1074

Finished checkout.

Note: checking out '85801e7b43730588c1e2770fb64d633c58d71759'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 85801e7... Change the load type for the phet-android-app query parameter, see https://github.com/phetsims/phet-android-app/issues/16

Finished checkout.

Note: checking out '3255de0f1edda165ff360076051a56cd31cd3ea5'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 3255de0... Adding Scenery build for Yotta use

Finished checkout.

Note: checking out 'a6bd3909751e280b7fdbe2f0ecd9ec066d152ff5'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at a6bd390... fix copy-paste error in doc

Finished checkout.

Note: checking out '569939e1f45973234a3819255a88cd2b80006f76'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 569939e... Moved dot TTypes to dot repo, see https://github.com/phetsims/phet-io/issues/1032

Finished checkout.

Note: checking out '81166ce9735f0bcb11b9e68b74eeed46b6f24da6'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 81166ce... Fix SVG-parser parseFloat usage (no radix), and use different comment style for visibility. See https://github.com/phetsims/kite/issues/68

Finished checkout.

Note: checking out 'ab42a2b92849293697db12d3ca148756f5b79dfb'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at ab42a2b... Don't show updates for any type of phet app, see https://github.com/phetsims/phet-android-app/issues/16

Finished checkout.

Note: checking out '2d1b574e80bcf70cbc1ae7ccda6289a51a98875b'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 2d1b574... added locales for the UK and Canada, see https://github.com/phetsims/rosetta/issues/149

Finished checkout.

Note: checking out 'bffd225eb8be0412385b8c542bcf8edc282fe31d'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at bffd225... fix formatting

Finished checkout.

Note: checking out '6213dc27544de739f31722d59f1a756e20ca03fb'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 6213dc2... add timeout to alerts as workaround for slow accessibility tree refresh rate, see #290

Finished checkout.

Note: checking out '4619049e07623c09c616fe8853387a4c8a7bed2a'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 4619049e... Using textContent instead, see https://github.com/phetsims/special-ops/issues/68

Finished checkout.
up to date in 0.234s

Finished npm prune for repo unit-rates
+ grunt-eslint@19.0.0
added 111 packages in 7.795s

Finished npm update for repo unit-rates
removed 89 packages in 1.011s

Finished npm prune for repo chipper
+ grunt-eslint@19.0.0
+ request@2.83.0
+ load-grunt-tasks@3.5.2
+ jscpd@0.6.15
added 15 packages, removed 4 packages and updated 26 packages in 5.057s

Finished npm update for repo chipper

Done.
~/github/unit-rates$ grunt
Running "eslint:allFiles" (eslint) task

Running "clean" task

Running "requirejs-build" task
WARN: Output exceeds 32000 characters
WARN: Output exceeds 32000 characters
WARN: Output exceeds 32000 characters
WARN: Output exceeds 32000 characters
WARN: Output exceeds 32000 characters
WARN: Output exceeds 32000 characters
WARN: Output exceeds 32000 characters
WARN: Output exceeds 32000 characters
WARN: Output exceeds 32000 characters
WARN: Output exceeds 32000 characters

Running "after-requirejs-build" task

Done.
samreid commented 6 years ago

I tried running grunt checkout-shas --repo=unit-rates from perennial then grunt from unit rates and saw the same problem as in https://github.com/phetsims/unit-rates/issues/203#issuecomment-336634284

The sim_deployment.md instructions say the following:

I think the first bullet point means to run grunt checkout-shas from the sim, not from perennial. However, when running grunt checkout-shas from perennial, I tried doing the second bullet point and the build completed successfully. Hence it seems like the grunt checkout-shas from the sim already npm prunes and updates whereas perennial does not.

pixelzoom commented 6 years ago

@samreid said:

I think the first bullet point means to run grunt checkout-shas from the sim, not from perennial.

My understanding (from past discussions at dev meetings) is that we should be running "grunt checkout-shas" and "grunt checkout-master" from perennial, since it's supposed to handle the npm prune/update properly.

pixelzoom commented 6 years ago

Here's what I ended up having to do:

% cd unit-rates
% git checkout master
% cd perennial
% grunt checkout-shas --repo=unit-rates
% cd chipper
% npm prune
% npm update
% cd unit-rates
% npm prune
% npm update
% grunt

This is the first time I've had to do the npm steps manually when using perennial grunt tasks.

pixelzoom commented 6 years ago

I'll add an item to the developer meeting agenda to discuss whether (and why) we should be using the chipper vs grunt tasks for checkout-shas and checkout-master.

Unit Rates 1.0.4 is deployed. Closing.