search

phetsims / unit-rates

"Unit Rates" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 2 forks source link

Typo in `numerationOptions` #204

Closed samreid closed 6 years ago

samreid commented 6 years ago

Discovered during https://github.com/phetsims/tasks/issues/730#issuecomment-370860967

DoubleNumberLine.js has:

numerationOptions: null, // {*} options specific to the rate's numerator, see below

Whereas elsewhere in the file it is referred to as numeratorOptions

pixelzoom commented 6 years ago

Good catch. Ditto in MarkerEditorNode, MarkerNode, ShoppingScene.

pixelzoom commented 6 years ago

The typo appeared only in the default options, in all cases: numerationOptions: null. Since other usages were spelled correct, and the default value was null, fixing the name in the options hash had no negative side-effects. To be certain, I tested the affected components, and compared to the published version (1.0.4). The numerator looked correct in all cases.

Closing.