search

phetsims / utterance-queue

Alerting library powered by aria-live
MIT License
0 stars 2 forks source link

Chromebook workaround should only be used on ChromeOS #110

Closed jessegreenberg closed 1 year ago

jessegreenberg commented 1 year ago

The workaround is causing problems for iOS, see https://github.com/phetsims/quadrilateral/issues/423. Lets just use it when running on ChromeOS. We need to add the platform check to platform.js and opt out in SpeechSynthesisAnnouncer.

jessegreenberg commented 1 year ago

OK, I tested the platform detection on iOS Safari and Chrome, ChromeOS, Windows Chrome, macOS Chrome and Safari in conjunction with https://github.com/phetsims/quadrilateral/issues/423.

@zepumph would you mind spot checking these two commits?

zepumph commented 1 year ago

Looks great to me! Thanks