search

phetsims / utterance-queue

Alerting library powered by aria-live
http://scenerystack.org/
MIT License
1 stars 2 forks source link

VoiceOver voice changes when certain locales are selected. #114

Closed Nancy-Salpepi closed 1 year ago

Nancy-Salpepi commented 1 year ago

Test device MacBook Air M1 chip

Operating System 13.4

Browser Safari 16.5

Problem description Seen while testing https://github.com/phetsims/qa/issues/958, when selecting some locales (ex. romana, tieng viet, cestina) with VoiceOver, the voice changes when uttering "On screen text now in ____."

Visuals

https://github.com/phetsims/utterance-queue/assets/87318828/659eea8f-6818-46fd-8242-7dcf1d820353

jessegreenberg commented 1 year ago

I am guessing this would be fixed after the above commit. I am not able to test though. @Nancy-Salpepi an you please pull master and see if this changed the behavior?

Nancy-Salpepi commented 1 year ago

Sorry @jessegreenberg the behavior is still the same. In addition to the ones I mentioned earlier, I am seeing a combination of 2 voices sometimes. The original voice will say "on screen text now in" and the second voice will say the actual language. This behavior is seen with some of the locales that don't use the Roman alphabet--ex. Arabic, Chinese.

jessegreenberg commented 1 year ago

OK, thanks for checking @Nancy-Salpepi. One more attempt - the language will now be in its English string. Hopefully that will mean there is no localized characters to change the pronunciation.

Can you please try again?

Nancy-Salpepi commented 1 year ago

No voice changes this time (and with the English strings I learned what a lot of the languages were!). Every once in a while there is a slight delay the first time I click on a locale , but no delay if I click on it a second time.

Nancy-Salpepi commented 1 year ago

This also sounds good in master with NVDA.

jessegreenberg commented 1 year ago

Great, that is good news. Thanks for testing this @Nancy-Salpepi. This is a good improvement. I am assuming the delay is not related to this issue and is not severe enough to investigate so closing this one.