search

phetsims / utterance-queue

Alerting library powered by aria-live
http://scenerystack.org/
MIT License
1 stars 2 forks source link

CT: Utterance: announceImmediately failed: #116

Closed jessegreenberg closed 1 year ago

jessegreenberg commented 1 year ago

utterance-queue : top-level-unit-tests : unbuilt?ea&brand=phet-io http://128.138.93.172/continuous-testing/ct-snapshots/1697055935934/utterance-queue/utterance-queue-tests.html?ea&brand=phet-io 7 out of 8 tests passed. 1 failed. Utterance: announceImmediately failed: myUtterance announced immediately when Announcer was ready["This is my utterance text"] at Object. (http://128.138.93.172/continuous-testing/ct-snapshots/1697055935934/chipper/dist/js/utterance-queue/js/UtteranceTests.js:171:10)

jessegreenberg commented 1 year ago

I think this is happening because of this: https://github.com/phetsims/utterance-queue/blob/0be5d398a244a8c744d72ecc9a1e18057f626035/js/UtteranceTests.ts#L188

This "sleep" is a workaround to let the utteranceQueue step once. But at some point, we added a similar timeout to the AriaLiveAnnouncer. If on CT the AriaLiveAnnouncer timeout runs through first, we could definitely hit this assertion.

Ill add some delay to let the utteranceQueue move the last utterance through and come back to see if that fixes it.

jessegreenberg commented 1 year ago

This seems to be fixed.