phetsims / utterance-queue

Alerting library powered by aria-live
MIT License
0 stars 2 forks source link

prepareUtterance should test with instanceOf Utterance #21

Closed zepumph closed 3 years ago

zepumph commented 3 years ago

Discovered with https://github.com/phetsims/utterance-queue/issues/18. It would be most flexible, if we supported any type of AlertableDef, and just wrapped any non-Utterance in an Utterance instance. Tagging @jessegreenberg so he is aware.

zepumph commented 3 years ago

@jessegreenberg, does this feel safe to you?

jessegreenberg commented 3 years ago

Yes, this does feel safe and more correct, thanks!