search

phetsims / utterance-queue

Alerting library powered by aria-live
MIT License
0 stars 2 forks source link

Assertion should use AlertableDef.js #28

Closed zepumph closed 2 years ago

zepumph commented 2 years ago

https://github.com/phetsims/utterance-queue/blob/c5024988addef3818199c1bad305d4b9c6e1e385/js/Utterance.js#L77

This is out of date.

zepumph commented 2 years ago

This seems to have already happened.

https://github.com/phetsims/utterance-queue/blob/8607d56ac00a5a406d57a55c2d45c4a671039d74/js/Utterance.js#L82

But I see another spot.

@jessegreenberg will you please review?

jessegreenberg commented 2 years ago

Makes sense to me, thanks!