search

phetsims / utterance-queue

Alerting library powered by aria-live
MIT License
0 stars 2 forks source link

deprecate UtteranceQueue.addToFront() #36

Closed zepumph closed 2 years ago

zepumph commented 2 years ago

While working on https://github.com/phetsims/friction/issues/242, @jessegreenberg and I found that addToFront was actually not doing anything, and it was really confusing. We found a better way forward was to just addToBack, and to potentially clear() the queue first, because we wanted to interrupt what was in the queue.

@jessegreenberg, does it seem right to you to try to remove this function, or at least deprecate it so that people don't use it from here on? Please assign back to me to implement.

jessegreenberg commented 2 years ago

Yes, i am strongly in favor of removing addToFront.

zepumph commented 2 years ago

I did all the easy stuff. There are three usages of this in sims: Molarity, Greenhouse, and Friction. Friction will be handled in https://github.com/phetsims/friction/issues/242. I will create issues in Molarity and Greenhouse.

zepumph commented 2 years ago

Issues created. Anything else here @jessegreenberg?

jessegreenberg commented 2 years ago

Thanks for the deprecation warning and making issues, closing.