search

phetsims / utterance-queue

Alerting library powered by aria-live
MIT License
0 stars 2 forks source link

Utterance.alertMaximumDelay is broken #39

Closed zepumph closed 2 years ago

zepumph commented 2 years ago

I found this while working on https://github.com/phetsims/sun/issues/730. I added a alertMaximumDelay and it was completely broken. From investigation I found two issues in the newly written removeOthersAndUpdateUtteranceWrapper function, and wrote tests to confirm the fix into the future. Commits comming soon.

zepumph commented 2 years ago

@jessegreenberg, does this look good to you?

jessegreenberg commented 2 years ago

This looks great, sorry for the bug and thank you for fixing this.