search

phetsims / utterance-queue

Alerting library powered by aria-live
MIT License
0 stars 2 forks source link

Deprecate AriaLiveAnnouncer.announcingEmitter #41

Closed zepumph closed 2 years ago

zepumph commented 2 years ago

From https://github.com/phetsims/joist/issues/752, we now have a more consistent robust API for this feature, and it doesn't look like the change will be that invasive.

zepumph commented 2 years ago

There is a TODO pointing to this issue.

zepumph commented 2 years ago

Done above. I needed access to the value of Utterance.getAlertText without the side effects, from tests, so I created Utterance.previousAlertText. In general it makes things a bit easier, since otherwise we can't get that value from the Utterance (a responseCollector Property could have changed in the interim).

@jessegreenberg please review.

jessegreenberg commented 2 years ago

These changes look good to me, thanks for taking this on.