phetsims / utterance-queue

Alerting library powered by aria-live
MIT License
0 stars 2 forks source link

Utterances can be removed from the queue as a side effect of Announcer.announce #45

Closed jessegreenberg closed 2 years ago

jessegreenberg commented 2 years ago

See https://github.com/phetsims/joist/issues/752#issuecomment-1015639358. To reproduce, fuzz a sim that supports voicing and do not click into the simulation. Description of the stack that causes this:

I like the assertion in removeUtterance, but we need to be more graceful after calling attemptToAnnounce.

jessegreenberg commented 2 years ago

I believe this is fixed. @zepumph would you please review this change?

zepumph commented 2 years ago

Makes sense to me. Thanks for the quick turnaround!

jessegreenberg commented 2 years ago

Great, thanks.