search

phetsims / utterance-queue

Alerting library powered by aria-live
MIT License
0 stars 2 forks source link

UtteranceQueue implementAsSkeleton should not conditionally instrument #61

Closed zepumph closed 2 years ago

zepumph commented 2 years ago

Lots has changed since this original, conditional instrumentation of utteranceQueue. It is better to just always create, as stated by @samreid in https://github.com/phetsims/phet-io/issues/1584#issuecomment-614068438

I'll adjust that.

zepumph commented 2 years ago

Ok. I made improvements here as @samreid recommended over in https://github.com/phetsims/phet-io/issues/1584#issuecomment-614068438. Please note that there is a bit more overhaul to do in https://github.com/phetsims/utterance-queue/issues/17, but this is a good start in my opinion.