search

phetsims / utterance-queue

Alerting library powered by aria-live
MIT License
0 stars 2 forks source link

UtteranceQueue.cancelUtterance should remove an Utterance from the queue #68

Closed jessegreenberg closed 2 years ago

jessegreenberg commented 2 years ago

Currently it just forwards the cancel to the announcer but I think the correct behavior would be to also remove the provided utterance form the queue if it is provided. This is causing https://github.com/phetsims/joist/issues/782 and if the utterance were removed from the queue in cancelUtterance we wouldn't have that issue.

jessegreenberg commented 2 years ago

Done in the above commit, seems to be working and unit tests still pass.